r190560 - [CMake] Fix repository version checking dependencies harder.

[Argyrios Kyrtzidis]

On Sep 11, 2013, at 7:32 PM, David Majnemer <david.majnemer at gmail.com> wrote:

> This commit causes no-op builds to relink which is slow. Why was this changed in the first place?

Yes, I find this awful. Why don't we generate a temporary file and replace SVNVersion.inc only if it is different ?

> 
> 
> On Wed, Sep 11, 2013 at 4:12 PM, Jordan Rose <jordan_rose at apple.com> wrote:
> Author: jrose
> Date: Wed Sep 11 18:12:55 2013
> New Revision: 190560
> 
> URL: http://llvm.org/viewvc/llvm-project?rev=190560&view=rev
> Log:
> [CMake] Fix repository version checking dependencies harder.
> 
> Just always regenerate SVNVersion.inc. Don't worry about it not changing.
> 
> Modified:
>     cfe/trunk/lib/Basic/CMakeLists.txt
> 
> Modified: cfe/trunk/lib/Basic/CMakeLists.txt
> URL: http://llvm.org/viewvc/llvm-project/cfe/trunk/lib/Basic/CMakeLists.txt?rev=190560&r1=190559&r2=190560&view=diff
> ==============================================================================
> --- cfe/trunk/lib/Basic/CMakeLists.txt (original)
> +++ cfe/trunk/lib/Basic/CMakeLists.txt Wed Sep 11 18:12:55 2013
> @@ -60,4 +60,4 @@ add_dependencies(clangBasic
>  )
> 
>  add_custom_command(TARGET clangBasic POST_BUILD
> -  COMMAND ${CMAKE_COMMAND} -E touch ${CMAKE_CURRENT_BINARY_DIR}/SVNVersion.inc)
> +  COMMAND ${CMAKE_COMMAND} -E remove ${CMAKE_CURRENT_BINARY_DIR}/SVNVersion.inc)
> 
> 
> _______________________________________________
> cfe-commits mailing list
> cfe-commits at cs.uiuc.edu
> http://lists.cs.uiuc.edu/mailman/listinfo/cfe-commits
> 
> _______________________________________________
> cfe-commits mailing list
> cfe-commits at cs.uiuc.edu
> http://lists.cs.uiuc.edu/mailman/listinfo/cfe-commits

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.llvm.org/pipermail/cfe-commits/attachments/20130912/b5a956e9/attachment.html>