<html><head><meta http-equiv="Content-Type" content="text/html charset=iso-8859-1"></head><body style="word-wrap: break-word; -webkit-nbsp-mode: space; -webkit-line-break: after-white-space; "><div><div>On Sep 11, 2013, at 7:32 PM, David Majnemer <<a href="mailto:david.majnemer@gmail.com">david.majnemer@gmail.com</a>> wrote:</div><br class="Apple-interchange-newline"><blockquote type="cite"><div dir="ltr">This commit causes no-op builds to relink which is slow. Why was this changed in the first place?</div></blockquote><div><br></div><div>Yes, I find this awful. Why don't we generate a temporary file and replace SVNVersion.inc only if it is different ?</div><br><blockquote type="cite"><div class="gmail_extra"><br><br><div class="gmail_quote">On Wed, Sep 11, 2013 at 4:12 PM, Jordan Rose <span dir="ltr"><<a href="mailto:jordan_rose@apple.com" target="_blank">jordan_rose@apple.com</a>></span> wrote:<br>
<blockquote class="gmail_quote" style="margin: 0px 0px 0px 0.8ex; border-left-width: 1px; border-left-color: rgb(204, 204, 204); border-left-style: solid; padding-left: 1ex; position: static; z-index: auto; ">Author: jrose<br>
Date: Wed Sep 11 18:12:55 2013<br>
New Revision: 190560<br>
<br>
URL: <a href="http://llvm.org/viewvc/llvm-project?rev=190560&view=rev" target="_blank">http://llvm.org/viewvc/llvm-project?rev=190560&view=rev</a><br>
Log:<br>
[CMake] Fix repository version checking dependencies harder.<br>
<br>
Just always regenerate SVNVersion.inc. Don't worry about it not changing.<br>
<br>
Modified:<br>
cfe/trunk/lib/Basic/CMakeLists.txt<br>
<br>
Modified: cfe/trunk/lib/Basic/CMakeLists.txt<br>
URL: <a href="http://llvm.org/viewvc/llvm-project/cfe/trunk/lib/Basic/CMakeLists.txt?rev=190560&r1=190559&r2=190560&view=diff" target="_blank">http://llvm.org/viewvc/llvm-project/cfe/trunk/lib/Basic/CMakeLists.txt?rev=190560&r1=190559&r2=190560&view=diff</a><br>
==============================================================================<br>
--- cfe/trunk/lib/Basic/CMakeLists.txt (original)<br>
+++ cfe/trunk/lib/Basic/CMakeLists.txt Wed Sep 11 18:12:55 2013<br>
@@ -60,4 +60,4 @@ add_dependencies(clangBasic<br>
)<br>
<br>
add_custom_command(TARGET clangBasic POST_BUILD<br>
- COMMAND ${CMAKE_COMMAND} -E touch ${CMAKE_CURRENT_BINARY_DIR}/SVNVersion.inc)<br>
+ COMMAND ${CMAKE_COMMAND} -E remove ${CMAKE_CURRENT_BINARY_DIR}/SVNVersion.inc)<br>
<br>
<br>
_______________________________________________<br>
cfe-commits mailing list<br>
<a href="mailto:cfe-commits@cs.uiuc.edu">cfe-commits@cs.uiuc.edu</a><br>
<a href="http://lists.cs.uiuc.edu/mailman/listinfo/cfe-commits" target="_blank">http://lists.cs.uiuc.edu/mailman/listinfo/cfe-commits</a><br>
</blockquote></div><br></div>
_______________________________________________<br>cfe-commits mailing list<br><a href="mailto:cfe-commits@cs.uiuc.edu">cfe-commits@cs.uiuc.edu</a><br>http://lists.cs.uiuc.edu/mailman/listinfo/cfe-commits<br></blockquote></div><br></body></html>