[PATCH] Header guard warning is too agressive

[Richard Smith]

rtrieu would be a more appropriate reviewer for this.


On Wed, Sep 11, 2013 at 1:15 PM, Ismail Pazarbasi <
ismail.pazarbasi at gmail.com> wrote:

>
>   Ping! This also fixes PR17053.
>
>
> ================
> Comment at: lib/Lex/PPLexerChange.cpp:280
> @@ +279,3 @@
> +              << ControllingMacro
> +              << FixItHint::CreateReplacement(
> +
>  CurPPLexer->MIOpt.GetDefinedLocation(),
> ----------------
> I haven't tried thoroughly, but I guess it'd be better to print the fix-it
> on the warning instead of the note, because clang-check will ignore the
> note (and I need clang-check to apply the fixit).
>
>
> http://llvm-reviews.chandlerc.com/D1506
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.llvm.org/pipermail/cfe-commits/attachments/20130911/09915c63/attachment.html>