<div dir="ltr">rtrieu would be a more appropriate reviewer for this.</div><div class="gmail_extra"><br><br><div class="gmail_quote">On Wed, Sep 11, 2013 at 1:15 PM, Ismail Pazarbasi <span dir="ltr"><<a href="mailto:ismail.pazarbasi@gmail.com" target="_blank">ismail.pazarbasi@gmail.com</a>></span> wrote:<br>
<blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex"><br>
  Ping! This also fixes PR17053.<br>
<br>
<br>
================<br>
Comment at: lib/Lex/PPLexerChange.cpp:280<br>
@@ +279,3 @@<br>
<div class="im">+              << ControllingMacro<br>
+              << FixItHint::CreateReplacement(<br>
+                                              CurPPLexer->MIOpt.GetDefinedLocation(),<br>
</div>----------------<br>
I haven't tried thoroughly, but I guess it'd be better to print the fix-it on the warning instead of the note, because clang-check will ignore the note (and I need clang-check to apply the fixit).<br>
<br>
<br>
<a href="http://llvm-reviews.chandlerc.com/D1506" target="_blank">http://llvm-reviews.chandlerc.com/D1506</a><br>
</blockquote></div><br></div>