r189893 - Add a diagnostic group for the "ignoring (static|inline) keyword on

[Richard Smith]

On Tue, Sep 3, 2013 at 5:10 PM, Peter Collingbourne <peter at pcc.me.uk> wrote:

> Author: pcc
> Date: Tue Sep  3 19:10:25 2013
> New Revision: 189893
>
> URL: http://llvm.org/viewvc/llvm-project?rev=189893&view=rev
> Log:
> Add a diagnostic group for the "ignoring (static|inline) keyword on
> explicit template instantiation" warning.
>
> Modified:
>     cfe/trunk/include/clang/Basic/DiagnosticParseKinds.td
>     cfe/trunk/test/Misc/warning-flags.c
>
> Modified: cfe/trunk/include/clang/Basic/DiagnosticParseKinds.td
> URL:
> http://llvm.org/viewvc/llvm-project/cfe/trunk/include/clang/Basic/DiagnosticParseKinds.td?rev=189893&r1=189892&r2=189893&view=diff
>
> ==============================================================================
> --- cfe/trunk/include/clang/Basic/DiagnosticParseKinds.td (original)
> +++ cfe/trunk/include/clang/Basic/DiagnosticParseKinds.td Tue Sep  3
> 19:10:25 2013
> @@ -616,7 +616,7 @@ def warn_cxx98_compat_extern_template :
>    InGroup<CXX98CompatPedantic>, DefaultIgnore;
>  def warn_static_inline_explicit_inst_ignored : Warning<
>    "ignoring '%select{static|inline}0' keyword on explicit template "
> -  "instantiation">;
> +  "instantiation">,
> InGroup<DiagGroup<"static-inline-explicit-instantiation">>;
>

Hmm, shouldn't this be an ExtWarn, not a Warning?

... also, we print this diagnostic on declarations that are not explicit
instantiations. Ugh.


>  // Constructor template diagnostics.
>  def err_out_of_line_constructor_template_id : Error<
>
> Modified: cfe/trunk/test/Misc/warning-flags.c
> URL:
> http://llvm.org/viewvc/llvm-project/cfe/trunk/test/Misc/warning-flags.c?rev=189893&r1=189892&r2=189893&view=diff
>
> ==============================================================================
> --- cfe/trunk/test/Misc/warning-flags.c (original)
> +++ cfe/trunk/test/Misc/warning-flags.c Tue Sep  3 19:10:25 2013
> @@ -18,7 +18,7 @@ This test serves two purposes:
>
>  The list of warnings below should NEVER grow.  It should gradually shrink
> to 0.
>
> -CHECK: Warnings without flags (136):
> +CHECK: Warnings without flags (135):
>  CHECK-NEXT:   ext_delete_void_ptr_operand
>  CHECK-NEXT:   ext_expected_semi_decl_list
>  CHECK-NEXT:   ext_explicit_specialization_storage_class
> @@ -141,7 +141,6 @@ CHECK-NEXT:   warn_redeclaration_without
>  CHECK-NEXT:   warn_register_objc_catch_parm
>  CHECK-NEXT:   warn_related_result_type_compatibility_class
>  CHECK-NEXT:   warn_related_result_type_compatibility_protocol
> -CHECK-NEXT:   warn_static_inline_explicit_inst_ignored
>  CHECK-NEXT:   warn_static_non_static
>  CHECK-NEXT:   warn_template_export_unsupported
>  CHECK-NEXT:   warn_template_spec_extra_headers
>
>
> _______________________________________________
> cfe-commits mailing list
> cfe-commits at cs.uiuc.edu
> http://lists.cs.uiuc.edu/mailman/listinfo/cfe-commits
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.llvm.org/pipermail/cfe-commits/attachments/20130903/9c68608b/attachment.html>