<div dir="ltr">On Tue, Sep 3, 2013 at 5:10 PM, Peter Collingbourne <span dir="ltr"><<a href="mailto:peter@pcc.me.uk" target="_blank">peter@pcc.me.uk</a>></span> wrote:<br><div class="gmail_extra"><div class="gmail_quote">
<blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">Author: pcc<br>
Date: Tue Sep  3 19:10:25 2013<br>
New Revision: 189893<br>
<br>
URL: <a href="http://llvm.org/viewvc/llvm-project?rev=189893&view=rev" target="_blank">http://llvm.org/viewvc/llvm-project?rev=189893&view=rev</a><br>
Log:<br>
Add a diagnostic group for the "ignoring (static|inline) keyword on<br>
explicit template instantiation" warning.<br>
<br>
Modified:<br>
    cfe/trunk/include/clang/Basic/DiagnosticParseKinds.td<br>
    cfe/trunk/test/Misc/warning-flags.c<br>
<br>
Modified: cfe/trunk/include/clang/Basic/DiagnosticParseKinds.td<br>
URL: <a href="http://llvm.org/viewvc/llvm-project/cfe/trunk/include/clang/Basic/DiagnosticParseKinds.td?rev=189893&r1=189892&r2=189893&view=diff" target="_blank">http://llvm.org/viewvc/llvm-project/cfe/trunk/include/clang/Basic/DiagnosticParseKinds.td?rev=189893&r1=189892&r2=189893&view=diff</a><br>

==============================================================================<br>
--- cfe/trunk/include/clang/Basic/DiagnosticParseKinds.td (original)<br>
+++ cfe/trunk/include/clang/Basic/DiagnosticParseKinds.td Tue Sep  3 19:10:25 2013<br>
@@ -616,7 +616,7 @@ def warn_cxx98_compat_extern_template :<br>
   InGroup<CXX98CompatPedantic>, DefaultIgnore;<br>
 def warn_static_inline_explicit_inst_ignored : Warning<<br>
   "ignoring '%select{static|inline}0' keyword on explicit template "<br>
-  "instantiation">;<br>
+  "instantiation">, InGroup<DiagGroup<"static-inline-explicit-instantiation">>;<br></blockquote><div><br></div><div>Hmm, shouldn't this be an ExtWarn, not a Warning?</div><div><br>
</div><div>... also, we print this diagnostic on declarations that are not explicit instantiations. Ugh.</div><div> </div><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">

 // Constructor template diagnostics.<br>
 def err_out_of_line_constructor_template_id : Error<<br>
<br>
Modified: cfe/trunk/test/Misc/warning-flags.c<br>
URL: <a href="http://llvm.org/viewvc/llvm-project/cfe/trunk/test/Misc/warning-flags.c?rev=189893&r1=189892&r2=189893&view=diff" target="_blank">http://llvm.org/viewvc/llvm-project/cfe/trunk/test/Misc/warning-flags.c?rev=189893&r1=189892&r2=189893&view=diff</a><br>

==============================================================================<br>
--- cfe/trunk/test/Misc/warning-flags.c (original)<br>
+++ cfe/trunk/test/Misc/warning-flags.c Tue Sep  3 19:10:25 2013<br>
@@ -18,7 +18,7 @@ This test serves two purposes:<br>
<br>
 The list of warnings below should NEVER grow.  It should gradually shrink to 0.<br>
<br>
-CHECK: Warnings without flags (136):<br>
+CHECK: Warnings without flags (135):<br>
 CHECK-NEXT:   ext_delete_void_ptr_operand<br>
 CHECK-NEXT:   ext_expected_semi_decl_list<br>
 CHECK-NEXT:   ext_explicit_specialization_storage_class<br>
@@ -141,7 +141,6 @@ CHECK-NEXT:   warn_redeclaration_without<br>
 CHECK-NEXT:   warn_register_objc_catch_parm<br>
 CHECK-NEXT:   warn_related_result_type_compatibility_class<br>
 CHECK-NEXT:   warn_related_result_type_compatibility_protocol<br>
-CHECK-NEXT:   warn_static_inline_explicit_inst_ignored<br>
 CHECK-NEXT:   warn_static_non_static<br>
 CHECK-NEXT:   warn_template_export_unsupported<br>
 CHECK-NEXT:   warn_template_spec_extra_headers<br>
<br>
<br>
_______________________________________________<br>
cfe-commits mailing list<br>
<a href="mailto:cfe-commits@cs.uiuc.edu">cfe-commits@cs.uiuc.edu</a><br>
<a href="http://lists.cs.uiuc.edu/mailman/listinfo/cfe-commits" target="_blank">http://lists.cs.uiuc.edu/mailman/listinfo/cfe-commits</a><br>
</blockquote></div><br></div></div>