[PATCH] [-cxx-abi microsoft] Change the vdtor implicit "should_call_delete" argument type to int
Timur Iskhodzhanov
timurrrr at google.com
Tue Aug 27 03:45:21 PDT 2013
John,
I hope this patch is trivial enough so you can review post-commit.
Committed the updated version as r189336.
================
Comment at: lib/CodeGen/MicrosoftCXXABI.cpp:442
@@ -441,2 +441,3 @@
if (Type == Dtor_Deleting) {
// The scalar deleting destructor takes an implicit bool parameter.
+ ArgTys.push_back(CGM.getContext().IntTy);
----------------
Reid Kleckner wrote:
> You should fix the comment, maybe to say an "implicit bitfield parameter".
Yeah, I've forgotten to update the comments and use the -U flag to provide more context...
Thanks for catching this - fixed!
================
Comment at: lib/CodeGen/MicrosoftCXXABI.cpp:639
@@ -639,2 +639,2 @@
ASTContext &Context = CGF.getContext();
----------------
There's a "bool" in a comment above [not shown in this context] - fixed too!
http://llvm-reviews.chandlerc.com/D1514
More information about the cfe-commits
mailing list