[PATCH] [-cxx-abi microsoft] Change the vdtor implicit "should_call_delete" argument type to int
Reid Kleckner
rnk at google.com
Mon Aug 26 13:04:03 PDT 2013
LGTM
There's not much context in the diff, but we might have more comments that talk about a boolean parameter that need fixing.
================
Comment at: lib/CodeGen/MicrosoftCXXABI.cpp:442
@@ -441,2 +441,3 @@
if (Type == Dtor_Deleting) {
// The scalar deleting destructor takes an implicit bool parameter.
+ ArgTys.push_back(CGM.getContext().IntTy);
----------------
You should fix the comment, maybe to say an "implicit bitfield parameter".
http://llvm-reviews.chandlerc.com/D1514
More information about the cfe-commits
mailing list