XCore make test checks more concise

[Robert Lytton]

(http://clang.llvm.org/docs/DriverInternals.html)
Now I get it!

So test should be:
// RUN: %clang -target xcore %s -### -o %t.o 2>&1 | FileCheck  %s
// CHECK: "-momit-leaf-frame-pointer"
// CHECK: "-fno-signed-char"
// CHECK: "-fno-common"

I'm a bit bothered that there is no "-fomit-frame-pointer".
Should I see this too?

Thank you

Robert

clang version 3.4 (trunk 188456) (llvm/trunk 188457)
Target: xcore
Thread model: posix
 "/home/robert/sandbox/tools_llvm-3.3/obj/Release+Asserts/bin/clang" "-cc1" "-triple" "xcore" "-S" "-disable-free" "-main-file-name" "xcore-opts.c" "-mrelocation-model" "static" "-fmath-errno" "-mconstructor-aliases" "-target-linker-version" "2.22" "-momit-leaf-frame-pointer" "-resource-dir" "/home/robert/sandbox/tools_llvm-3.3/obj/Release+Asserts/bin/../lib/clang/3.4" "-fno-dwarf-directory-asm" "-fdebug-compilation-dir" "/home/robert/sandbox/tools_llvm-3.3/obj/tools/clang/test/Driver" "-ferror-limit" "19" "-fmessage-length" "0" "-mstackrealign" "-fno-signed-char" "-fobjc-runtime=gcc" "-fobjc-default-synthesize-properties" "-fno-common" "-fdiagnostics-show-option" "-vectorize-slp" "-o" "/tmp/xcore-opts-da67ba.s" "-x" "c" "/home/robert/sandbox/tools_llvm-3.3/src/tools/clang/test/Driver/xcore-opts.c"
 "/usr/bin/gcc" "-c" "-o" "/tmp/xcore-opts-c86ac4.o" "-x" "assembler" "/tmp/xcore-opts-da67ba.s"
 "/usr/bin/gcc" "-o" "/home/robert/sandbox/tools_llvm-3.3/obj/tools/clang/test/Driver/Output/xcore-opts.c.tmp.o" "/tmp/xcore-opts-c86ac4.o"

________________________________________
From: Rafael Espíndola [rafael.espindola at gmail.com]
Sent: 15 August 2013 18:38
To: Robert Lytton
Cc: cfe-commits at cs.uiuc.edu
Subject: Re: XCore make test checks more concise

Can't you test that by checking the clang -cc1 invocation?

On 15 August 2013 09:59, Robert Lytton <robert at xmos.com> wrote:
> Hi Rafael,
>
> The test was originally there to test changes in the driver - defaults for the target.
> URL: http://llvm.org/viewvc/llvm-project/cfe/trunk/lib/Driver/Tools.cpp?rev=188258&r1=188257&r2=188258&view=diff
>
> Robert
>
>
> ________________________________________
> From: Rafael Espíndola [rafael.espindola at gmail.com]
> Sent: 15 August 2013 17:00
> To: Robert Lytton
> Cc: cfe-commits at cs.uiuc.edu
> Subject: Re: XCore make test checks more concise
>
> This test is odd. It is running the driver and checking IL. Driver
> tests normally check the commands that the driver is executing (like
> clang -cc1) by passing -### to the driver.
>
> If the objective is to check IL, it should not be a driver test and
> use %clang_cc1 instead.
>
> On 15 August 2013 06:51, Robert Lytton <robert at xmos.com> wrote:
>> Hi,
>>
>> Small patch to make a couple of tests more concise.
>> (highlights echoed below)
>>
>> Robert
>>
>>
>> -// CHECK: @g1 = global i32 0, align 4
>> +// CHECK: @g1 = global
>>  int g1;
>>
>>
>> -// CHECK-LABEL: define zeroext i8 @testchar()
>> +// CHECK: define zeroext i8 @testchar()
>>  char testchar (void) {
>>
>>
>> _______________________________________________
>> cfe-commits mailing list
>> cfe-commits at cs.uiuc.edu
>> http://lists.cs.uiuc.edu/mailman/listinfo/cfe-commits
>>