XCore make test checks more concise

[Rafael Espíndola]

Can't you test that by checking the clang -cc1 invocation?

On 15 August 2013 09:59, Robert Lytton <robert at xmos.com> wrote:
> Hi Rafael,
>
> The test was originally there to test changes in the driver - defaults for the target.
> URL: http://llvm.org/viewvc/llvm-project/cfe/trunk/lib/Driver/Tools.cpp?rev=188258&r1=188257&r2=188258&view=diff
>
> Robert
>
>
> ________________________________________
> From: Rafael Espíndola [rafael.espindola at gmail.com]
> Sent: 15 August 2013 17:00
> To: Robert Lytton
> Cc: cfe-commits at cs.uiuc.edu
> Subject: Re: XCore make test checks more concise
>
> This test is odd. It is running the driver and checking IL. Driver
> tests normally check the commands that the driver is executing (like
> clang -cc1) by passing -### to the driver.
>
> If the objective is to check IL, it should not be a driver test and
> use %clang_cc1 instead.
>
> On 15 August 2013 06:51, Robert Lytton <robert at xmos.com> wrote:
>> Hi,
>>
>> Small patch to make a couple of tests more concise.
>> (highlights echoed below)
>>
>> Robert
>>
>>
>> -// CHECK: @g1 = global i32 0, align 4
>> +// CHECK: @g1 = global
>>  int g1;
>>
>>
>> -// CHECK-LABEL: define zeroext i8 @testchar()
>> +// CHECK: define zeroext i8 @testchar()
>>  char testchar (void) {
>>
>>
>> _______________________________________________
>> cfe-commits mailing list
>> cfe-commits at cs.uiuc.edu
>> http://lists.cs.uiuc.edu/mailman/listinfo/cfe-commits
>>