N3644 tests for map/multimap/set/multiset

Marshall Clow mclow.lists at gmail.com
Wed Aug 7 15:14:55 PDT 2013

On Aug 7, 2013, at 12:08 PM, Howard Hinnant <hhinnant at apple.com> wrote:

> On Aug 6, 2013, at 2:39 PM, Marshall Clow <mclow.lists at gmail.com> wrote:
>> The existing implementations seem to work, so I just added some tests.
> Your tests are passing by accident.  __tree_iterator and __tree_const_iterator in <__tree> need treatment for their default actor.

Ok. So I fixed that

>> The general iterator tests for <map> appeared to be missing, so I added that, too.
> Thanks, but this is covered in map/map.access/iterator.pass.cpp.

Moved them.

And I made the __tree_const_iterator () constructor noexcept 

Revised patch attached.

-- Marshall

Marshall Clow     Idio Software   <mailto:mclow.lists at gmail.com>

A.D. 1517: Martin Luther nails his 95 Theses to the church door and is promptly moderated down to (-1, Flamebait).
        -- Yu Suzuki
-------------- next part --------------
A non-text attachment was scrubbed...
Name: n3644-7.2.patch
Type: application/octet-stream
Size: 3845 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/cfe-commits/attachments/20130807/075bc33f/attachment.obj>

More information about the cfe-commits mailing list