N3644 tests for map/multimap/set/multiset

Howard Hinnant hhinnant at apple.com
Wed Aug 7 12:08:27 PDT 2013

On Aug 6, 2013, at 2:39 PM, Marshall Clow <mclow.lists at gmail.com> wrote:

> The existing implementations seem to work, so I just added some tests.

Your tests are passing by accident.  __tree_iterator and __tree_const_iterator in <__tree> need treatment for their default ctor.

> The general iterator tests for <map> appeared to be missing, so I added that, too.

Thanks, but this is covered in map/map.access/iterator.pass.cpp.

I'd rather not have commented out tests.  I believe these will work as intended if uncommented.


More information about the cfe-commits mailing list