r186817 - Implement the part of C89 6.5.7 p3 requiring a constant initializer list

[Eli Friedman]

On Mon, Jul 22, 2013 at 6:29 AM, Enea Zaffanella <zaffanella at cs.unipr.it> wrote:
> On 07/22/2013 02:28 PM, NAKAMURA Takumi wrote:
>>
>> It brings bunch of warnings in c-index-test.c with c89 mode.
>> Shall we tweak c-index-test.c as c89-compliant, or should I suppress
>> warnings with -Wno-c99-extensions in my builders?
>
>
> As for me, no strong opinions in this respect ...
> I guess the question to be answered is whether or not c-index-test.c was
> originally meant to be c89 compliant.

It's not really meant to be C89-compliant... but as a practical
matter, if we disable the warnings, it becomes much easier to break
compilation with MSVC.

-Eli