Use of sys::fs::copy_file in the ARC Migration tool

[Argyrios Kyrtzidis]

Removed the code in r186462, thanks!

On Jul 16, 2013, at 11:17 AM, Rafael Espíndola <rafael.espindola at gmail.com> wrote:

> While working on something else I stumbled on a use of
> sys::fs::copy_file in FileRemapper::overwriteOriginal. Given that it
> looks like the function wants to move temporary files over originals,
> it should probably be using rename, no?
> 
> I wrote the attached use_rename.patch,  but then noticed that no test
> touches this code path. In fact, the attached dead.patch causes no
> failures :-(
> 
> Is the code actually dead? If not, any ideas for a testcase that would
> execute it? If it is not dead, should it be using rename?
> 
> Cheers,
> Rafael
> <use_rename.patch><dead.patch>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.llvm.org/pipermail/cfe-commits/attachments/20130716/dedf88d3/attachment.html>