<html><head><meta http-equiv="Content-Type" content="text/html charset=iso-8859-1"></head><body style="word-wrap: break-word; -webkit-nbsp-mode: space; -webkit-line-break: after-white-space;"><div>Removed the code in r186462, thanks!</div><br><div><div>On Jul 16, 2013, at 11:17 AM, Rafael Espíndola <<a href="mailto:rafael.espindola@gmail.com">rafael.espindola@gmail.com</a>> wrote:</div><br class="Apple-interchange-newline"><blockquote type="cite"><div style="font-size: 12px; font-style: normal; font-variant: normal; font-weight: normal; letter-spacing: normal; line-height: normal; orphans: auto; text-align: start; text-indent: 0px; text-transform: none; white-space: normal; widows: auto; word-spacing: 0px; -webkit-text-stroke-width: 0px;">While working on something else I stumbled on a use of<br>sys::fs::copy_file in FileRemapper::overwriteOriginal. Given that it<br>looks like the function wants to move temporary files over originals,<br>it should probably be using rename, no?<br><br>I wrote the attached use_rename.patch, but then noticed that no test<br>touches this code path. In fact, the attached dead.patch causes no<br>failures :-(<br><br>Is the code actually dead? If not, any ideas for a testcase that would<br>execute it? If it is not dead, should it be using rename?<br><br>Cheers,<br>Rafael<br><span><use_rename.patch></span><span><dead.patch></span></div></blockquote></div><br></body></html>