[PATCH] [Driver] Refactor clang driver to use LLVM's Option library

Manuel Klimek klimek at google.com
Thu Jun 13 23:38:42 PDT 2013


On Fri, Jun 14, 2013 at 7:43 AM, Tobias Grosser <tobias at grosser.es> wrote:

> On 06/13/2013 11:39 AM, Reid Kleckner wrote:
> [...]
>
>
>> clang-format produced some formattings that I'm not sure are standard
>> LLVM style.  They look like:
>>    ReturnTypeIsReallyLong
>>        methodNameIsAlsoUnusuallyLong(**ParamTy P1, ParamTy P2);
>>
>> I think I see this more commonly:
>>    ReturnTypeIsReallyLong
>>    methodNameIsAlsoUnusuallyLong(**ParamTy P1, ParamTy P2);
>> Or:
>>    ReturnTypeIsReallyLong methodNameIsAlsoUnusuallyLong(**ParamTy P1,
>>                                                         ParamTy P2);
>>
>> I figured I should ask up front if that's OK, and if not, it's probably
>> best to go fix clang-format, re-run, and resend.
>>
>
> I believe this is a bug in clang-format that was introduced about two
> weeks ago. I reported it at llvm.org/PR16157 and would very much like
> to get it fixed.
>

Wondering why I didn't get an email notification when you filed this... is
there a way to configure that myself in bugzilla (I assume not...)


> Cheers,
> Tobias
>
> ______________________________**_________________
> cfe-commits mailing list
> cfe-commits at cs.uiuc.edu
> http://lists.cs.uiuc.edu/**mailman/listinfo/cfe-commits<http://lists.cs.uiuc.edu/mailman/listinfo/cfe-commits>
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.llvm.org/pipermail/cfe-commits/attachments/20130614/28bbddcc/attachment.html>


More information about the cfe-commits mailing list