[PATCH] [Driver] Refactor clang driver to use LLVM's Option library

Tobias Grosser tobias at grosser.es
Thu Jun 13 22:43:33 PDT 2013


On 06/13/2013 11:39 AM, Reid Kleckner wrote:
[...]
>
> clang-format produced some formattings that I'm not sure are standard
> LLVM style.  They look like:
>    ReturnTypeIsReallyLong
>        methodNameIsAlsoUnusuallyLong(ParamTy P1, ParamTy P2);
>
> I think I see this more commonly:
>    ReturnTypeIsReallyLong
>    methodNameIsAlsoUnusuallyLong(ParamTy P1, ParamTy P2);
> Or:
>    ReturnTypeIsReallyLong methodNameIsAlsoUnusuallyLong(ParamTy P1,
>                                                         ParamTy P2);
>
> I figured I should ask up front if that's OK, and if not, it's probably
> best to go fix clang-format, re-run, and resend.

I believe this is a bug in clang-format that was introduced about two 
weeks ago. I reported it at llvm.org/PR16157 and would very much like
to get it fixed.

Cheers,
Tobias



More information about the cfe-commits mailing list