r183717 - [libclang] Allow building a precompiled preamble with compiler errors

[Argyrios Kyrtzidis]

On Jun 10, 2013, at 10:34 PM, Tobias Grosser <tobias at grosser.es> wrote:

> On 06/10/2013 05:36 PM, Argyrios Kyrtzidis wrote:
>> Author: akirtzidis
>> Date: Mon Jun 10 19:36:55 2013
>> New Revision: 183717
>> 
>> URL: http://llvm.org/viewvc/llvm-project?rev=183717&view=rev
>> Log:
>> [libclang] Allow building a precompiled preamble with compiler errors
>> 
>> A while ago we allowed libclang to build a PCH that had compiler errors; this was to retain the performance
>> afforded by a PCH even if the user's code is in an intermediate state.
>> 
>> Extend this for the precompiled preamble as well.
>> 
>> rdar://14109828
> 
> Very nice. Thanks a lot!
> 
>> 
>> -  if (Diagnostics->hasErrorOccurred()) {
>> +  if (!Act->hasEmittedPreamblePCH()) {
>>      // There were errors parsing the preamble, so no precompiled header was
>>      // generated. Forget that we even tried.
>>      // FIXME: Should we leave a note for ourselves to try again?
> 
> Just to be sure: Is this comment still up to date?

I've made it more accurate in r183751.

> 
> Tobi

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.llvm.org/pipermail/cfe-commits/attachments/20130611/8f8796fe/attachment.html>