<html><head><meta http-equiv="Content-Type" content="text/html charset=iso-8859-1"></head><body style="word-wrap: break-word; -webkit-nbsp-mode: space; -webkit-line-break: after-white-space;"><br><div><div>On Jun 10, 2013, at 10:34 PM, Tobias Grosser <<a href="mailto:tobias@grosser.es">tobias@grosser.es</a>> wrote:</div><br class="Apple-interchange-newline"><blockquote type="cite"><div style="letter-spacing: normal; orphans: auto; text-align: start; text-indent: 0px; text-transform: none; white-space: normal; widows: auto; word-spacing: 0px; -webkit-text-stroke-width: 0px;">On 06/10/2013 05:36 PM, Argyrios Kyrtzidis wrote:<br><blockquote type="cite">Author: akirtzidis<br>Date: Mon Jun 10 19:36:55 2013<br>New Revision: 183717<br><br>URL: <a href="http://llvm.org/viewvc/llvm-project?rev=183717&view=rev">http://llvm.org/viewvc/llvm-project?rev=183717&view=rev</a><br>Log:<br>[libclang] Allow building a precompiled preamble with compiler errors<br><br>A while ago we allowed libclang to build a PCH that had compiler errors; this was to retain the performance<br>afforded by a PCH even if the user's code is in an intermediate state.<br><br>Extend this for the precompiled preamble as well.<br><br><a href="rdar://14109828">rdar://14109828</a><br></blockquote><br>Very nice. Thanks a lot!<br><br><blockquote type="cite"><br>- if (Diagnostics->hasErrorOccurred()) {<br>+ if (!Act->hasEmittedPreamblePCH()) {<br> // There were errors parsing the preamble, so no precompiled header was<br> // generated. Forget that we even tried.<br> // FIXME: Should we leave a note for ourselves to try again?<br></blockquote><br>Just to be sure: Is this comment still up to date?<br></div></blockquote><div dir="auto"><br></div><div dir="auto">I've made it more accurate in r183751.</div><br><blockquote type="cite"><div style="letter-spacing: normal; orphans: auto; text-align: start; text-indent: 0px; text-transform: none; white-space: normal; widows: auto; word-spacing: 0px; -webkit-text-stroke-width: 0px;"><br>Tobi</div></blockquote></div><br></body></html>