[PATCH] Initial clang-tidy architecture

Daniel Jasper djasper at google.com
Wed May 29 13:46:45 PDT 2013


  YAML sounds awesome, but I think it is too early to say what gets configured and where.


================
Comment at: clang-tidy/ClangTidy.h:26
@@ +25,3 @@
+/// automatic fix.
+struct ClangTidyError {
+  ClangTidyError(const SourceManager &Sources, SourceLocation Loc,
----------------
João Matos wrote:
> Is there any reason we can't re-use Clang's Diagnostic class here?
Yes. Diagnostics are SourceManager (i.e. translation unit) specific. These errors will be collected over several compilations units, combined and the printed/fixed.

================
Comment at: clang-tidy/ClangTidy.h:67
@@ +66,3 @@
+/// \brief Run a set of clang-tidy checks on a set of files.
+ClangTidyErrors runClangTidy(StringRef CheckRegexString,
+                             const tooling::CompilationDatabase &Compilations,
----------------
João Matos wrote:
> From a tooling perspective, it'd be nice to have a better way to specify the set of checks to be enabled than one regex.
Agreed, but that can easily be extended later.


http://llvm-reviews.chandlerc.com/D884



More information about the cfe-commits mailing list