[PATCH] Initial clang-tidy architecture

João Matos ripzonetriton at gmail.com
Wed May 29 13:29:02 PDT 2013


  Are there any plans regarding support for external configuration files (YAML)?


================
Comment at: clang-tidy/ClangTidy.h:42
@@ +41,3 @@
+
+/// \brief Every \c ClangTidyCheck reports errors through a conetxt.
+class ClangTidyContext {
----------------
typo

================
Comment at: clang-tidy/ClangTidy.h:26
@@ +25,3 @@
+/// automatic fix.
+struct ClangTidyError {
+  ClangTidyError(const SourceManager &Sources, SourceLocation Loc,
----------------
Is there any reason we can't re-use Clang's Diagnostic class here?

================
Comment at: clang-tidy/ClangTidy.h:67
@@ +66,3 @@
+/// \brief Run a set of clang-tidy checks on a set of files.
+ClangTidyErrors runClangTidy(StringRef CheckRegexString,
+                             const tooling::CompilationDatabase &Compilations,
----------------
>From a tooling perspective, it'd be nice to have a better way to specify the set of checks to be enabled than one regex.


http://llvm-reviews.chandlerc.com/D884



More information about the cfe-commits mailing list