r182732 - Address post-review comment from dblakie.

David Blaikie dblaikie at gmail.com
Mon May 27 13:44:45 PDT 2013


On Mon, May 27, 2013 at 5:36 AM, Manuel Klimek <klimek at google.com> wrote:

> Author: klimek
> Date: Mon May 27 07:36:28 2013
> New Revision: 182732
>
> URL: http://llvm.org/viewvc/llvm-project?rev=182732&view=rev
> Log:
> Address post-review comment from dblakie.
>
> Modified:
>     cfe/trunk/lib/Format/UnwrappedLineParser.h
>
> Modified: cfe/trunk/lib/Format/UnwrappedLineParser.h
> URL:
> http://llvm.org/viewvc/llvm-project/cfe/trunk/lib/Format/UnwrappedLineParser.h?rev=182732&r1=182731&r2=182732&view=diff
>
> ==============================================================================
> --- cfe/trunk/lib/Format/UnwrappedLineParser.h (original)
> +++ cfe/trunk/lib/Format/UnwrappedLineParser.h Mon May 27 07:36:28 2013
> @@ -120,7 +120,7 @@ public:
>    // up-front.
>    virtual unsigned getPosition() { return 0; }
>    virtual FormatToken setPosition(unsigned Position) {
> -    assert(false);
> +    llvm_unreachable("Interface in transition; do not call!");
>      return FormatToken();
>

Removed this unreachable return in r182742, too.


>    }
>  };
>
>
> _______________________________________________
> cfe-commits mailing list
> cfe-commits at cs.uiuc.edu
> http://lists.cs.uiuc.edu/mailman/listinfo/cfe-commits
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.llvm.org/pipermail/cfe-commits/attachments/20130527/d7be9b3d/attachment.html>


More information about the cfe-commits mailing list