<div dir="ltr"><br><div class="gmail_extra"><br><br><div class="gmail_quote">On Mon, May 27, 2013 at 5:36 AM, Manuel Klimek <span dir="ltr"><<a href="mailto:klimek@google.com" target="_blank">klimek@google.com</a>></span> wrote:<br>
<blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">Author: klimek<br>
Date: Mon May 27 07:36:28 2013<br>
New Revision: 182732<br>
<br>
URL: <a href="http://llvm.org/viewvc/llvm-project?rev=182732&view=rev" target="_blank">http://llvm.org/viewvc/llvm-project?rev=182732&view=rev</a><br>
Log:<br>
Address post-review comment from dblakie.<br>
<br>
Modified:<br>
cfe/trunk/lib/Format/UnwrappedLineParser.h<br>
<br>
Modified: cfe/trunk/lib/Format/UnwrappedLineParser.h<br>
URL: <a href="http://llvm.org/viewvc/llvm-project/cfe/trunk/lib/Format/UnwrappedLineParser.h?rev=182732&r1=182731&r2=182732&view=diff" target="_blank">http://llvm.org/viewvc/llvm-project/cfe/trunk/lib/Format/UnwrappedLineParser.h?rev=182732&r1=182731&r2=182732&view=diff</a><br>
==============================================================================<br>
--- cfe/trunk/lib/Format/UnwrappedLineParser.h (original)<br>
+++ cfe/trunk/lib/Format/UnwrappedLineParser.h Mon May 27 07:36:28 2013<br>
@@ -120,7 +120,7 @@ public:<br>
// up-front.<br>
virtual unsigned getPosition() { return 0; }<br>
virtual FormatToken setPosition(unsigned Position) {<br>
- assert(false);<br>
+ llvm_unreachable("Interface in transition; do not call!");<br>
return FormatToken();<br></blockquote><div><br></div><div style>Removed this unreachable return in r182742, too.</div><div> </div><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">
}<br>
};<br>
<br>
<br>
_______________________________________________<br>
cfe-commits mailing list<br>
<a href="mailto:cfe-commits@cs.uiuc.edu">cfe-commits@cs.uiuc.edu</a><br>
<a href="http://lists.cs.uiuc.edu/mailman/listinfo/cfe-commits" target="_blank">http://lists.cs.uiuc.edu/mailman/listinfo/cfe-commits</a><br>
</blockquote></div><br></div></div>