[PATCH] OpenMP threadprivate with qualified names.

[Doug Gregor]

================
Comment at: include/clang/Basic/DiagnosticSemaKinds.td:6319
@@ +6318,3 @@
+def err_omp_threadprivate_incomplete_type : Error<
+  "a threadprivate variable with incomplete type %0">;
+} // end of OpenMP category
----------------
I suggest dropping the leading "a ". It doesn't add anything.

================
Comment at: lib/Parse/ParseOpenMP.cpp:81
@@ +80,3 @@
+  bool LParen = true;
+  if (Tok.isNot(tok::l_paren)) {
+    Diag(Tok, diag::err_expected_lparen_after)
----------------
Why did you remove the BalancedDelimiterTracker?

================
Comment at: lib/Sema/SemaOpenMP.cpp:93
@@ +92,3 @@
+    Diag(VD->getLocation(), IsDecl ? diag::note_previous_decl :
+                                     diag::note_defined_here) << VD;
+    return ExprError();
----------------
Please wrap the IsDecl ? argument to the next line. The formatting here is a bit too unique.


http://llvm-reviews.chandlerc.com/D717