[PATCH] OpenMP threadprivate with qualified names.

[Hal Finkel]

----- Original Message -----
> From: "Alexey Bataev" <a.bataev at hotmail.com>
> To: dgregor at apple.com, gribozavr at gmail.com, hfinkel at anl.gov, "a bataev" <a.bataev at hotmail.com>
> Cc: cfe-commits at cs.uiuc.edu, "wei pan" <wei.pan at intel.com>
> Sent: Tuesday, April 23, 2013 11:53:40 PM
> Subject: [PATCH] OpenMP threadprivate with qualified names.
> 
> Hi doug.gregor, gribozavr, hfinkel,
> 
> Hello Doug, Hal, Dmitri,
> Here is a patch with support of qualified names in '#pragma omp
> threadprivate'.

Alexey, good to see this!

To provide everyone else with some context: this is a change in behavior from the initial threadprivate implementation (which disallowed qualified ids) motivated by a conversation we had with the OpenMP language committee. The consensus was that qualified ids should be allowed, albeit in this limited fashion. This is implied by the syntax summary appendix in the new OpenMP 4 (draft) specification, although had not been explicitly stated in the normative text (thus the confusion on our part).

 -Hal

> 
> PS. This patch was the part of '#pragma omp parallel', but I think it
> would be better to review it separately.
> 
> Best regards,
> Alexey Bataev
> =============
> Software Engineer
> Intel Compiler Team
> Intel Corp.
> 
> http://llvm-reviews.chandlerc.com/D717
> 
> Files:
>   test/OpenMP/predefined_macro.c
>   test/OpenMP/threadprivate_messages.cpp
>   include/clang/Basic/DiagnosticParseKinds.td
>   include/clang/Basic/DiagnosticSemaKinds.td
>   include/clang/Sema/Sema.h
>   include/clang/AST/DeclOpenMP.h
>   include/clang/Parse/Parser.h
>   lib/Basic/OpenMPKinds.cpp
>   lib/Sema/SemaOpenMP.cpp
>   lib/Sema/SemaTemplateInstantiateDecl.cpp
>   lib/AST/DeclPrinter.cpp
>   lib/AST/DeclOpenMP.cpp
>   lib/Parse/ParseOpenMP.cpp
>   lib/Serialization/ASTReaderDecl.cpp
>