[PATCH] FreeBSD: Set the ARM EABI version when using an external assembler

[Renato Golin]

On 17 March 2013 00:49, Andrew Turner <andrew at fubar.geek.nz> wrote:

> On FreeBSD when we build ARM EABI elf files with clang the EABI version
> bits in elf flags field are unset. According the the ABI documentation
> this indicates an unknown conformance level.
>

I'm curious as to what problems did this cause... Cross-compiler GCC also
produces ABI Version: 0.


The attached patch sets the EABI value to the same as if the LLVM
> integrated assembler was used, i.e. 5. It also updates the FreeBSD
> Driver test to check the value is set.
>

You're changing both EABI and GNUEABI but only testing one of them.

I can't see any problem arising from this change, but I'm still curious as
to why this is needed. I may be wrong, but I think that "version 0" is
assumed to be the current version. So, the only real need to set an ABI
version would be if there was a new one that would break this one (which is
very unlikely).

Being that the case, I think we shouldn't force ABI version 5 on all EABI
binaries produced from clang. And since you can do that via command line,
there's no rush in getting it in either.

cheers,
--renato
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.llvm.org/pipermail/cfe-commits/attachments/20130317/4bb4fd22/attachment.html>