r176942 - Add llvm-symbolizer as test dependency.

[Jordan Rose]

On Mar 13, 2013, at 14:21 , Alexey Samsonov <samsonov at google.com> wrote:

> Hi!
> 
> On Wed, Mar 13, 2013 at 8:04 PM, Jordan Rose <jordan_rose at apple.com> wrote:
> 1) Does this need to be added to the Makefile build as well?
> 
> Um, at first glance I can't see how to define that a test suite depends on a certain tool…

Ah, I guess in Make we just depend on LLVM implicitly being built first.

> 2) Should this be conditional on having compiler-rt?
> 
> No, llvm-symbolizer doesn't depend on compiler-rt. "ASan or MSan" mentioned in
> the commit message are turned on in the compiler flags of host compiler.

Oh, the host compiler, not the built compiler. My bad. (If this were more expensive, I'd say it should be conditional on building with asan/msan, but llvm-symbolizer is light enough that it's fine to have the rest of us building it too.)

Jordan
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.llvm.org/pipermail/cfe-commits/attachments/20130313/9a91f6f4/attachment.html>