r176942 - Add llvm-symbolizer as test dependency.

[Alexey Samsonov]

Hi!

On Wed, Mar 13, 2013 at 8:04 PM, Jordan Rose <jordan_rose at apple.com> wrote:

> 1) Does this need to be added to the Makefile build as well?
>

Um, at first glance I can't see how to define that a test suite depends on
a certain tool...


> 2) Should this be conditional on having compiler-rt?
>

No, llvm-symbolizer doesn't depend on compiler-rt. "ASan or MSan" mentioned
in
the commit message are turned on in the compiler flags of host compiler.


>
> Jordan
>
>
> On Mar 13, 2013, at 2:36 , Evgeniy Stepanov <eugeni.stepanov at gmail.com>
> wrote:
>
> > Author: eugenis
> > Date: Wed Mar 13 04:36:02 2013
> > New Revision: 176942
> >
> > URL: http://llvm.org/viewvc/llvm-project?rev=176942&view=rev
> > Log:
> > Add llvm-symbolizer as test dependency.
> >
> > It is required when building tests with ASan or MSan.
> >
> > Modified:
> >    cfe/trunk/test/CMakeLists.txt
> >
> > Modified: cfe/trunk/test/CMakeLists.txt
> > URL:
> http://llvm.org/viewvc/llvm-project/cfe/trunk/test/CMakeLists.txt?rev=176942&r1=176941&r2=176942&view=diff
> >
> ==============================================================================
> > --- cfe/trunk/test/CMakeLists.txt (original)
> > +++ cfe/trunk/test/CMakeLists.txt Wed Mar 13 04:36:02 2013
> > @@ -44,7 +44,7 @@ endif()
> >
> > if( NOT CLANG_BUILT_STANDALONE )
> >   list(APPEND CLANG_TEST_DEPS
> > -    llc opt FileCheck count not
> > +    llc opt FileCheck count not llvm-symbolizer
> >     )
> >
> >   add_lit_testsuite(check-clang "Running the Clang regression tests"
> >
> >
> > _______________________________________________
> > cfe-commits mailing list
> > cfe-commits at cs.uiuc.edu
> > http://lists.cs.uiuc.edu/mailman/listinfo/cfe-commits
>
> _______________________________________________
> cfe-commits mailing list
> cfe-commits at cs.uiuc.edu
> http://lists.cs.uiuc.edu/mailman/listinfo/cfe-commits
>



-- 
Alexey Samsonov, MSK
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.llvm.org/pipermail/cfe-commits/attachments/20130314/1e23a57f/attachment.html>