r176949 - Refactoring:
Anton Yartsev
anton.yartsev at gmail.com
Wed Mar 13 10:10:05 PDT 2013
On 13.03.2013 20:10, Jordan Rose wrote:
> Thanks for the cleanup!
>
> On Mar 13, 2013, at 7:39 , Anton Yartsev <anton.yartsev at gmail.com
> <mailto:anton.yartsev at gmail.com>> wrote:
>
>> + if (Interesting)
>> + R->markInteresting(Sym);
>> + R->addVisitor(new MallocBugVisitor(Sym));
>
> This is not the same logic; the previous code tracked /both/ symbols
> in the case of a realloc:
>
> int *x = malloc(4); // $sym1
> int *y = realloc(x, 5); // $sym2
> if (y)
> free(x); // use-after-free, should track both symbols.
>
> Sorry we didn't catch that sooner.
Fixed at r176956
--
Anton
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.llvm.org/pipermail/cfe-commits/attachments/20130313/90a96052/attachment.html>
More information about the cfe-commits
mailing list