<html>
<head>
<meta content="text/html; charset=ISO-8859-1"
http-equiv="Content-Type">
</head>
<body text="#000000" bgcolor="#FFFFFF">
<div class="moz-cite-prefix">On 13.03.2013 20:10, Jordan Rose wrote:<br>
</div>
<blockquote
cite="mid:B7A37BF8-122A-41A9-8672-7CE42207D995@apple.com"
type="cite">
<meta http-equiv="Content-Type" content="text/html;
charset=ISO-8859-1">
<div>Thanks for the cleanup!</div>
<br>
<div>
<div>On Mar 13, 2013, at 7:39 , Anton Yartsev <<a
moz-do-not-send="true" href="mailto:anton.yartsev@gmail.com">anton.yartsev@gmail.com</a>>
wrote:</div>
<br class="Apple-interchange-newline">
<blockquote type="cite"><span style="font-family: monospace;
font-size: medium; font-style: normal; font-variant: normal;
font-weight: normal; letter-spacing: normal; line-height:
normal; orphans: 2; text-align: -webkit-auto; text-indent:
0px; text-transform: none; white-space: normal; widows: 2;
word-spacing: 0px; -webkit-text-size-adjust: auto;
-webkit-text-stroke-width: 0px; display: inline !important;
float: none; ">+ if (Interesting)</span><br
style="font-family: monospace; font-size: medium;
font-style: normal; font-variant: normal; font-weight:
normal; letter-spacing: normal; line-height: normal;
orphans: 2; text-align: -webkit-auto; text-indent: 0px;
text-transform: none; white-space: normal; widows: 2;
word-spacing: 0px; -webkit-text-size-adjust: auto;
-webkit-text-stroke-width: 0px; ">
<span style="font-family: monospace; font-size: medium;
font-style: normal; font-variant: normal; font-weight:
normal; letter-spacing: normal; line-height: normal;
orphans: 2; text-align: -webkit-auto; text-indent: 0px;
text-transform: none; white-space: normal; widows: 2;
word-spacing: 0px; -webkit-text-size-adjust: auto;
-webkit-text-stroke-width: 0px; display: inline !important;
float: none; ">+ R->markInteresting(Sym);</span><br
style="font-family: monospace; font-size: medium;
font-style: normal; font-variant: normal; font-weight:
normal; letter-spacing: normal; line-height: normal;
orphans: 2; text-align: -webkit-auto; text-indent: 0px;
text-transform: none; white-space: normal; widows: 2;
word-spacing: 0px; -webkit-text-size-adjust: auto;
-webkit-text-stroke-width: 0px; ">
<span style="font-family: monospace; font-size: medium;
font-style: normal; font-variant: normal; font-weight:
normal; letter-spacing: normal; line-height: normal;
orphans: 2; text-align: -webkit-auto; text-indent: 0px;
text-transform: none; white-space: normal; widows: 2;
word-spacing: 0px; -webkit-text-size-adjust: auto;
-webkit-text-stroke-width: 0px; display: inline !important;
float: none; ">+ R->addVisitor(new
MallocBugVisitor(Sym));</span><br style="font-family:
monospace; font-size: medium; font-style: normal;
font-variant: normal; font-weight: normal; letter-spacing:
normal; line-height: normal; orphans: 2; text-align:
-webkit-auto; text-indent: 0px; text-transform: none;
white-space: normal; widows: 2; word-spacing: 0px;
-webkit-text-size-adjust: auto; -webkit-text-stroke-width:
0px; ">
</blockquote>
</div>
<br>
<div>This is not the same logic; the previous code tracked <i>both</i> symbols
in the case of a realloc:</div>
<div><br>
</div>
<div>int *x = malloc(4); // $sym1</div>
<div>int *y = realloc(x, 5); // $sym2</div>
<div>if (y)</div>
<div><span class="Apple-tab-span" style="white-space:pre"> </span>free(x);
// use-after-free, should track both symbols.</div>
<div><br>
</div>
<div>Sorry we didn't catch that sooner.</div>
</blockquote>
Fixed at r176956<br>
<br>
<pre class="moz-signature" cols="72">--
Anton</pre>
</body>
</html>