r176428 - Perform non-overload placeholder conversions on the operands

[Richard Smith]

On Mon, Mar 4, 2013 at 2:54 PM, Richard Smith <richard at metafoo.co.uk> wrote:

> On Sun, Mar 3, 2013 at 5:30 PM, John McCall <rjmccall at apple.com> wrote:
>
>> Author: rjmccall
>> Date: Sun Mar  3 19:30:55 2013
>> New Revision: 176428
>>
>> URL: http://llvm.org/viewvc/llvm-project?rev=176428&view=rev
>> Log:
>> Perform non-overload placeholder conversions on the operands
>> to a subscript operator.
>>
>> rdar://13332183
>>
>> Modified:
>>     cfe/trunk/lib/Sema/SemaExpr.cpp
>>     cfe/trunk/test/SemaCXX/overloaded-operator.cpp
>>     cfe/trunk/test/SemaObjCXX/properties.mm
>>
>> Modified: cfe/trunk/lib/Sema/SemaExpr.cpp
>> URL:
>> http://llvm.org/viewvc/llvm-project/cfe/trunk/lib/Sema/SemaExpr.cpp?rev=176428&r1=176427&r2=176428&view=diff
>>
>> ==============================================================================
>> --- cfe/trunk/lib/Sema/SemaExpr.cpp (original)
>> +++ cfe/trunk/lib/Sema/SemaExpr.cpp Sun Mar  3 19:30:55 2013
>> @@ -3341,33 +3341,56 @@ static bool checkArithmeticOnObjCPointer
>>  }
>>
>>  ExprResult
>> -Sema::ActOnArraySubscriptExpr(Scope *S, Expr *Base, SourceLocation LLoc,
>> -                              Expr *Idx, SourceLocation RLoc) {
>> +Sema::ActOnArraySubscriptExpr(Scope *S, Expr *base, SourceLocation lbLoc,
>> +                              Expr *idx, SourceLocation rbLoc) {
>>
>
> Why the conversion away from the coding-style-approved
> VariableCapitalization?
>

Hey John,

Not sure if you missed this message. Several more of your recent commits
have converted variables from the InitialCaps style required by the coding
standard to an initialLowercase form.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.llvm.org/pipermail/cfe-commits/attachments/20130308/0cd2a4c9/attachment.html>