On Mon, Mar 4, 2013 at 2:54 PM, Richard Smith <span dir="ltr"><<a href="mailto:richard@metafoo.co.uk" target="_blank">richard@metafoo.co.uk</a>></span> wrote:<br><div class="gmail_quote"><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">
<div class="im">On Sun, Mar 3, 2013 at 5:30 PM, John McCall <span dir="ltr"><<a href="mailto:rjmccall@apple.com" target="_blank">rjmccall@apple.com</a>></span> wrote:<br></div><div class="gmail_quote"><div class="im">
<blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">
Author: rjmccall<br>
Date: Sun Mar  3 19:30:55 2013<br>
New Revision: 176428<br>
<br>
URL: <a href="http://llvm.org/viewvc/llvm-project?rev=176428&view=rev" target="_blank">http://llvm.org/viewvc/llvm-project?rev=176428&view=rev</a><br>
Log:<br>
Perform non-overload placeholder conversions on the operands<br>
to a subscript operator.<br>
<br>
rdar://13332183<br>
<br>
Modified:<br>
    cfe/trunk/lib/Sema/SemaExpr.cpp<br>
    cfe/trunk/test/SemaCXX/overloaded-operator.cpp<br>
    cfe/trunk/test/SemaObjCXX/<a href="http://properties.mm" target="_blank">properties.mm</a><br>
<br>
Modified: cfe/trunk/lib/Sema/SemaExpr.cpp<br>
URL: <a href="http://llvm.org/viewvc/llvm-project/cfe/trunk/lib/Sema/SemaExpr.cpp?rev=176428&r1=176427&r2=176428&view=diff" target="_blank">http://llvm.org/viewvc/llvm-project/cfe/trunk/lib/Sema/SemaExpr.cpp?rev=176428&r1=176427&r2=176428&view=diff</a><br>


==============================================================================<br>
--- cfe/trunk/lib/Sema/SemaExpr.cpp (original)<br>
+++ cfe/trunk/lib/Sema/SemaExpr.cpp Sun Mar  3 19:30:55 2013<br>
@@ -3341,33 +3341,56 @@ static bool checkArithmeticOnObjCPointer<br>
 }<br>
<br>
 ExprResult<br>
-Sema::ActOnArraySubscriptExpr(Scope *S, Expr *Base, SourceLocation LLoc,<br>
-                              Expr *Idx, SourceLocation RLoc) {<br>
+Sema::ActOnArraySubscriptExpr(Scope *S, Expr *base, SourceLocation lbLoc,<br>
+                              Expr *idx, SourceLocation rbLoc) {<br></blockquote><div><br></div></div><div>Why the conversion away from the coding-style-approved VariableCapitalization?</div></div></blockquote><div><br>
</div><div>Hey John,</div><div><br></div><div>Not sure if you missed this message. Several more of your recent commits have converted variables from the InitialCaps style required by the coding standard to an initialLowercase form.</div>
</div>