r175963 - Remove data member MSAsmStmt::AsmLoc, wrongly hiding AsmStmt::AsmLoc.

[Matthieu Monrocq]

On Sat, Feb 23, 2013 at 6:56 PM, David Blaikie <dblaikie at gmail.com> wrote:

>
>
>
> On Sat, Feb 23, 2013 at 4:27 AM, Enea Zaffanella <zaffanella at cs.unipr.it>wrote:
>
>> Author: enea
>> Date: Sat Feb 23 06:27:19 2013
>> New Revision: 175963
>>
>> URL: http://llvm.org/viewvc/llvm-project?rev=175963&view=rev
>> Log:
>> Remove data member MSAsmStmt::AsmLoc, wrongly hiding AsmStmt::AsmLoc.
>>
>
> Hmm - wonder how much value there might be in a warning for this.
>
>

None in the codebases I work on: the guideline is that attributes should be
private, so anyway they are not accessible from derived classes.

The question might be more general though, for example what of hidden
methods ?

-- Matthieu


>
>> Modified:
>>     cfe/trunk/include/clang/AST/Stmt.h
>>
>> Modified: cfe/trunk/include/clang/AST/Stmt.h
>> URL:
>> http://llvm.org/viewvc/llvm-project/cfe/trunk/include/clang/AST/Stmt.h?rev=175963&r1=175962&r2=175963&view=diff
>>
>> ==============================================================================
>> --- cfe/trunk/include/clang/AST/Stmt.h (original)
>> +++ cfe/trunk/include/clang/AST/Stmt.h Sat Feb 23 06:27:19 2013
>> @@ -1673,7 +1673,7 @@ public:
>>  /// This represents a Microsoft inline-assembly statement extension.
>>  ///
>>  class MSAsmStmt : public AsmStmt {
>> -  SourceLocation AsmLoc, LBraceLoc, EndLoc;
>> +  SourceLocation LBraceLoc, EndLoc;
>>    std::string AsmStr;
>>
>>    unsigned NumAsmToks;
>>
>>
>> _______________________________________________
>> cfe-commits mailing list
>> cfe-commits at cs.uiuc.edu
>> http://lists.cs.uiuc.edu/mailman/listinfo/cfe-commits
>>
>
>
> _______________________________________________
> cfe-commits mailing list
> cfe-commits at cs.uiuc.edu
> http://lists.cs.uiuc.edu/mailman/listinfo/cfe-commits
>
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.llvm.org/pipermail/cfe-commits/attachments/20130224/f37a5096/attachment.html>