<br><br><div class="gmail_quote">On Sat, Feb 23, 2013 at 6:56 PM, David Blaikie <span dir="ltr"><<a href="mailto:dblaikie@gmail.com" target="_blank">dblaikie@gmail.com</a>></span> wrote:<br><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">
<div dir="ltr"><br><div class="gmail_extra"><br><br><div class="gmail_quote">On Sat, Feb 23, 2013 at 4:27 AM, Enea Zaffanella <span dir="ltr"><<a href="mailto:zaffanella@cs.unipr.it" target="_blank">zaffanella@cs.unipr.it</a>></span> wrote:<br>

<blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">Author: enea<br>
Date: Sat Feb 23 06:27:19 2013<br>
New Revision: 175963<br>
<br>
URL: <a href="http://llvm.org/viewvc/llvm-project?rev=175963&view=rev" target="_blank">http://llvm.org/viewvc/llvm-project?rev=175963&view=rev</a><br>
Log:<br>
Remove data member MSAsmStmt::AsmLoc, wrongly hiding AsmStmt::AsmLoc.<br></blockquote><div><br></div><div>Hmm - wonder how much value there might be in a warning for this.</div><div> </div></div></div></div></blockquote>
<div><br>None in the codebases I work on: the guideline is that attributes should be private, so anyway they are not accessible from derived classes.<br><br>The question might be more general though, for example what of hidden methods ?<br>
<br>-- Matthieu<br> </div><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex"><div dir="ltr"><div class="gmail_extra"><div class="gmail_quote"><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">


<br>
Modified:<br>
    cfe/trunk/include/clang/AST/Stmt.h<br>
<br>
Modified: cfe/trunk/include/clang/AST/Stmt.h<br>
URL: <a href="http://llvm.org/viewvc/llvm-project/cfe/trunk/include/clang/AST/Stmt.h?rev=175963&r1=175962&r2=175963&view=diff" target="_blank">http://llvm.org/viewvc/llvm-project/cfe/trunk/include/clang/AST/Stmt.h?rev=175963&r1=175962&r2=175963&view=diff</a><br>


==============================================================================<br>
--- cfe/trunk/include/clang/AST/Stmt.h (original)<br>
+++ cfe/trunk/include/clang/AST/Stmt.h Sat Feb 23 06:27:19 2013<br>
@@ -1673,7 +1673,7 @@ public:<br>
 /// This represents a Microsoft inline-assembly statement extension.<br>
 ///<br>
 class MSAsmStmt : public AsmStmt {<br>
-  SourceLocation AsmLoc, LBraceLoc, EndLoc;<br>
+  SourceLocation LBraceLoc, EndLoc;<br>
   std::string AsmStr;<br>
<br>
   unsigned NumAsmToks;<br>
<br>
<br>
_______________________________________________<br>
cfe-commits mailing list<br>
<a href="mailto:cfe-commits@cs.uiuc.edu" target="_blank">cfe-commits@cs.uiuc.edu</a><br>
<a href="http://lists.cs.uiuc.edu/mailman/listinfo/cfe-commits" target="_blank">http://lists.cs.uiuc.edu/mailman/listinfo/cfe-commits</a><br>
</blockquote></div><br></div></div>
<br>_______________________________________________<br>
cfe-commits mailing list<br>
<a href="mailto:cfe-commits@cs.uiuc.edu">cfe-commits@cs.uiuc.edu</a><br>
<a href="http://lists.cs.uiuc.edu/mailman/listinfo/cfe-commits" target="_blank">http://lists.cs.uiuc.edu/mailman/listinfo/cfe-commits</a><br>
<br></blockquote></div><br>