r175483 - Fixing a typo where FixIts was accidentally self-assigning instead of assigning in the parameter Fixits. This fixes several failed assertions with MSVC debug builds.

[Chandler Carruth]

On Mon, Feb 18, 2013 at 6:32 PM, Aaron Ballman <aaron at aaronballman.com>wrote:

> Author: aaronballman
> Date: Mon Feb 18 20:32:05 2013
> New Revision: 175483
>
> URL: http://llvm.org/viewvc/llvm-project?rev=175483&view=rev
> Log:
> Fixing a typo where FixIts was accidentally self-assigning instead of
> assigning in the parameter Fixits. This fixes several failed assertions
> with MSVC debug builds.
>

Err, I think the fix should be to name the parameter FixIts. We often
specifically alias the member in the constructor parameter name so that
it's harder to typo.

Also, why is this using the assign member rather than using the 2-argument
constructor in the init list?


>
> Modified:
>     cfe/trunk/lib/Basic/Diagnostic.cpp
>
> Modified: cfe/trunk/lib/Basic/Diagnostic.cpp
> URL:
> http://llvm.org/viewvc/llvm-project/cfe/trunk/lib/Basic/Diagnostic.cpp?rev=175483&r1=175482&r2=175483&view=diff
>
> ==============================================================================
> --- cfe/trunk/lib/Basic/Diagnostic.cpp (original)
> +++ cfe/trunk/lib/Basic/Diagnostic.cpp Mon Feb 18 20:32:05 2013
> @@ -959,7 +959,7 @@ StoredDiagnostic::StoredDiagnostic(Diagn
>    : ID(ID), Level(Level), Loc(Loc), Message(Message)
>  {
>    this->Ranges.assign(Ranges.begin(), Ranges.end());
> -  this->FixIts.assign(FixIts.begin(), FixIts.end());
> +  this->FixIts.assign(Fixits.begin(), Fixits.end());
>  }
>
>  StoredDiagnostic::~StoredDiagnostic() { }
>
>
> _______________________________________________
> cfe-commits mailing list
> cfe-commits at cs.uiuc.edu
> http://lists.cs.uiuc.edu/mailman/listinfo/cfe-commits
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.llvm.org/pipermail/cfe-commits/attachments/20130218/8330577d/attachment.html>