<div dir="ltr">On Mon, Feb 18, 2013 at 6:32 PM, Aaron Ballman <span dir="ltr"><<a href="mailto:aaron@aaronballman.com" target="_blank" class="cremed">aaron@aaronballman.com</a>></span> wrote:<br><div class="gmail_extra">
<div class="gmail_quote"><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">Author: aaronballman<br>
Date: Mon Feb 18 20:32:05 2013<br>
New Revision: 175483<br>
<br>
URL: <a href="http://llvm.org/viewvc/llvm-project?rev=175483&view=rev" target="_blank" class="cremed">http://llvm.org/viewvc/llvm-project?rev=175483&view=rev</a><br>
Log:<br>
Fixing a typo where FixIts was accidentally self-assigning instead of assigning in the parameter Fixits. This fixes several failed assertions with MSVC debug builds.<br></blockquote><div><br></div><div style>Err, I think the fix should be to name the parameter FixIts. We often specifically alias the member in the constructor parameter name so that it's harder to typo.</div>
<div style><br></div><div style>Also, why is this using the assign member rather than using the 2-argument constructor in the init list?</div><div> </div><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">

<br>
Modified:<br>
    cfe/trunk/lib/Basic/Diagnostic.cpp<br>
<br>
Modified: cfe/trunk/lib/Basic/Diagnostic.cpp<br>
URL: <a href="http://llvm.org/viewvc/llvm-project/cfe/trunk/lib/Basic/Diagnostic.cpp?rev=175483&r1=175482&r2=175483&view=diff" target="_blank" class="cremed">http://llvm.org/viewvc/llvm-project/cfe/trunk/lib/Basic/Diagnostic.cpp?rev=175483&r1=175482&r2=175483&view=diff</a><br>

==============================================================================<br>
--- cfe/trunk/lib/Basic/Diagnostic.cpp (original)<br>
+++ cfe/trunk/lib/Basic/Diagnostic.cpp Mon Feb 18 20:32:05 2013<br>
@@ -959,7 +959,7 @@ StoredDiagnostic::StoredDiagnostic(Diagn<br>
   : ID(ID), Level(Level), Loc(Loc), Message(Message)<br>
 {<br>
   this->Ranges.assign(Ranges.begin(), Ranges.end());<br>
-  this->FixIts.assign(FixIts.begin(), FixIts.end());<br>
+  this->FixIts.assign(Fixits.begin(), Fixits.end());<br>
 }<br>
<br>
 StoredDiagnostic::~StoredDiagnostic() { }<br>
<br>
<br>
_______________________________________________<br>
cfe-commits mailing list<br>
<a href="mailto:cfe-commits@cs.uiuc.edu" class="cremed">cfe-commits@cs.uiuc.edu</a><br>
<a href="http://lists.cs.uiuc.edu/mailman/listinfo/cfe-commits" target="_blank" class="cremed">http://lists.cs.uiuc.edu/mailman/listinfo/cfe-commits</a><br>
</blockquote></div><br></div></div>