[PATCHJ] Fix for diagnosing half pointers/arrays

Tanya Lattner lattner at apple.com
Mon Feb 11 17:11:25 PST 2013


LGTM.

-Tanya

On Feb 11, 2013, at 6:14 AM, Joey Gouly <joey.gouly at arm.com> wrote:

> Hi John,
>> Just check whether the lvalue expression's type isHalfType() instead
>> of trying to enumerate all the syntactic cases that can give rise to it.
> Thanks. Please find a revised patch.
> 
> I also removed the opencl_cast_from_half diagnostic, since there isn't a
> valid case
> for "(float) expr", where expr would yield a half.
> 
> Any more comments?
> 
> Thanks,
> Joey
> 
> 
> 
> <half_type_fix_update.diff>_______________________________________________
> cfe-commits mailing list
> cfe-commits at cs.uiuc.edu
> http://lists.cs.uiuc.edu/mailman/listinfo/cfe-commits




More information about the cfe-commits mailing list