[PATCHJ] Fix for diagnosing half pointers/arrays

Joey Gouly joey.gouly at arm.com
Mon Feb 11 06:14:57 PST 2013


Hi John,
> Just check whether the lvalue expression's type isHalfType() instead
> of trying to enumerate all the syntactic cases that can give rise to it.
Thanks. Please find a revised patch.

I also removed the opencl_cast_from_half diagnostic, since there isn't a
valid case
for "(float) expr", where expr would yield a half.

Any more comments?

Thanks,
Joey



-------------- next part --------------
A non-text attachment was scrubbed...
Name: half_type_fix_update.diff
Type: application/octet-stream
Size: 5743 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/cfe-commits/attachments/20130211/d5421131/attachment.obj>


More information about the cfe-commits mailing list