[cfe-commits] r172413 - in /cfe/trunk: lib/Format/Format.cpp unittests/Format/FormatTest.cpp

[Chandler Carruth]

On Mon, Jan 14, 2013 at 8:26 AM, Tobias Grosser <tobias at grosser.es> wrote:

> On 01/14/2013 04:47 PM, Douglas Gregor wrote:
>
>>
>> On Jan 14, 2013, at 7:43 AM, Daniel Jasper <djasper at google.com
>> <mailto:djasper at google.com>> wrote:
>>
>>  Sure. I'll add this as an option and add a default style for Chromium
>>> (we have other stuff we want to configure according to the Chromium
>>> style guide).
>>>
>>
>> Thank you!
>>
>>  Douglas: Should I set this to break or no break for the default LLVM
>>> Style?
>>>
>>
>> Unfortunately, the style guide is itself inconsistent. Personally, I'd
>> prefer to break there.
>>
>
> I agree with Doug here.
>
> From reading LLVM code it seems that ifs without breaks exists, but to me
> they always look like something special.
>

FWIW, I third this across both LLVM and Clang. I don't even really think we
want the option for single line if statements now.... The arguments against
them are good, and the arguments for them are very very weak. Consistency
and simplicity says we should just format this the one way that definitely
works.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.llvm.org/pipermail/cfe-commits/attachments/20130116/f6732b29/attachment.html>