[cfe-commits] r172413 - in /cfe/trunk: lib/Format/Format.cpp unittests/Format/FormatTest.cpp

[Daniel Jasper]

Changed in r172431.


On Mon, Jan 14, 2013 at 5:26 PM, Tobias Grosser <tobias at grosser.es> wrote:

> On 01/14/2013 04:47 PM, Douglas Gregor wrote:
>
>>
>> On Jan 14, 2013, at 7:43 AM, Daniel Jasper <djasper at google.com
>> <mailto:djasper at google.com>> wrote:
>>
>>  Sure. I'll add this as an option and add a default style for Chromium
>>> (we have other stuff we want to configure according to the Chromium
>>> style guide).
>>>
>>
>> Thank you!
>>
>>  Douglas: Should I set this to break or no break for the default LLVM
>>> Style?
>>>
>>
>> Unfortunately, the style guide is itself inconsistent. Personally, I'd
>> prefer to break there.
>>
>
> I agree with Doug here.
>
> From reading LLVM code it seems that ifs without breaks exists, but to me
> they always look like something special.
>
> All the best,
> Tobi
>
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.llvm.org/pipermail/cfe-commits/attachments/20130114/c8a42415/attachment.html>