[cfe-commits] [Review] [ubsan] Fix type reported in compound assignment operations

Will Dietz wdietz2 at uiuc.edu
Sun Dec 30 00:13:30 PST 2012


See attached patches, thanks!

Description:

When checking "a += b" we were using the type of 'a' in the
diagnostic, instead of the type of the overflowing expression "a+b".
This was particularly problematic when 'a' was signed and 'b' was
unsigned.

Okay to commit?

~Will
-------------- next part --------------
A non-text attachment was scrubbed...
Name: 0001-ubsan-Use-correct-type-for-compound-assignment-ops.patch
Type: application/octet-stream
Size: 1145 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/cfe-commits/attachments/20121230/77572546/attachment.obj>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: 0001-ubsan-Check-for-appropriate-types-on-compound-assign.patch
Type: application/octet-stream
Size: 4075 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/cfe-commits/attachments/20121230/77572546/attachment-0001.obj>


More information about the cfe-commits mailing list