[cfe-commits] r171013 - /cfe/trunk/lib/CodeGen/CGDecl.cpp

[Jordan Rose]

The array cases actually make logical sense, since the arrayBegin and the arrayEndPointer parameters together represent a single logical parameter. However, can we just convert these to (Mutable)ArrayRef and fix that?

Jordan


On Dec 23, 2012, at 17:48 , NAKAMURA Takumi <geek4civic at gmail.com> wrote:

> Author: chapuni
> Date: Sun Dec 23 19:48:59 2012
> New Revision: 171013
> 
> URL: http://llvm.org/viewvc/llvm-project?rev=171013&view=rev
> Log:
> CGDecl.cpp: Prune three descriptions in two methods, CodeGenFunction::pushIrregularPartialArrayCleanup() and CodeGenFunction::pushRegularPartialArrayCleanup(). [-Wdocumentation]
> 
> /// \param array - a value of type elementType*
> /// \param destructionKind - the kind of destruction required
> /// \param initializedElementCount - a value of type size_t* holding the number of successfully-constructed elements
> 
> Modified:
>    cfe/trunk/lib/CodeGen/CGDecl.cpp
> 
> Modified: cfe/trunk/lib/CodeGen/CGDecl.cpp
> URL: http://llvm.org/viewvc/llvm-project/cfe/trunk/lib/CodeGen/CGDecl.cpp?rev=171013&r1=171012&r2=171013&view=diff
> ==============================================================================
> --- cfe/trunk/lib/CodeGen/CGDecl.cpp (original)
> +++ cfe/trunk/lib/CodeGen/CGDecl.cpp Sun Dec 23 19:48:59 2012
> @@ -1434,10 +1434,6 @@
> ///
> /// \param elementType - the immediate element type of the array;
> ///   possibly still an array type
> -/// \param array - a value of type elementType*
> -/// \param destructionKind - the kind of destruction required
> -/// \param initializedElementCount - a value of type size_t* holding
> -///   the number of successfully-constructed elements
> void CodeGenFunction::pushIrregularPartialArrayCleanup(llvm::Value *arrayBegin,
>                                                  llvm::Value *arrayEndPointer,
>                                                        QualType elementType,
> @@ -1453,10 +1449,6 @@
> ///
> /// \param elementType - the immediate element type of the array;
> ///   possibly still an array type
> -/// \param array - a value of type elementType*
> -/// \param destructionKind - the kind of destruction required
> -/// \param initializedElementCount - a value of type size_t* holding
> -///   the number of successfully-constructed elements
> void CodeGenFunction::pushRegularPartialArrayCleanup(llvm::Value *arrayBegin,
>                                                      llvm::Value *arrayEnd,
>                                                      QualType elementType,
> 
> 
> _______________________________________________
> cfe-commits mailing list
> cfe-commits at cs.uiuc.edu
> http://lists.cs.uiuc.edu/mailman/listinfo/cfe-commits