[cfe-commits] clang formatter patch to move and rename RewriterTestContext.h

[jahanian]

On Dec 20, 2012, at 9:36 AM, Douglas Gregor <dgregor at apple.com> wrote:

> 
> On Dec 20, 2012, at 9:35 AM, Daniel Jasper <djasper at google.com> wrote:
> 
>> 
>> 
>> 
>> On Thu, Dec 20, 2012 at 6:30 PM, Douglas Gregor <dgregor at apple.com> wrote:
>> 
>> On Dec 20, 2012, at 9:02 AM, Daniel Jasper <djasper at google.com> wrote:
>> 
>>> Hi,
>>> 
>>> ok, some comments here, but after the discussions it seems like this can mostly go in as is.
>>> 
>>> +    TT_BlockComment,
>>> +    TT_ObjectiveCMethodDecl
>>>    };
>>> 
>>> The +/- actually determine whether it is an instance or a static method, right? If so, we might want to hint at that in this name.
>> 
>> Yes, that's true. The formatter shouldn't care whether it's dealing with an instance vs. class method (they're conventionally formatted the same way), so why distinguish?
>> 
>> That's not what I meant. I meant something like TT_ObjCStaticOrInstanceSpecifier (probably not a good name). But the enum value should say some thing about the single token and I was suspecting that the +/- by themselves are not method declarations.
> 
> Ah. +/- are only used for method declarations, so TT_ObjCMethodSpecifier would be suitable descriptive.

OK. I will use this name.

- Fariborz


-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.llvm.org/pipermail/cfe-commits/attachments/20121220/ae10a318/attachment.html>