<html><head><meta http-equiv="Content-Type" content="text/html charset=iso-8859-1"></head><body style="word-wrap: break-word; -webkit-nbsp-mode: space; -webkit-line-break: after-white-space; "><br><div><div>On Dec 20, 2012, at 9:36 AM, Douglas Gregor <<a href="mailto:dgregor@apple.com">dgregor@apple.com</a>> wrote:</div><br class="Apple-interchange-newline"><blockquote type="cite"><meta http-equiv="Content-Type" content="text/html charset=iso-8859-1"><div style="word-wrap: break-word; -webkit-nbsp-mode: space; -webkit-line-break: after-white-space; "><br><div><div>On Dec 20, 2012, at 9:35 AM, Daniel Jasper <<a href="mailto:djasper@google.com">djasper@google.com</a>> wrote:</div><br class="Apple-interchange-newline"><blockquote type="cite"><div style="font-family: arial, helvetica, sans-serif; font-size: 10pt"><div dir="ltr"><br><div class="gmail_extra"><br><br><div class="gmail_quote">On Thu, Dec 20, 2012 at 6:30 PM, Douglas Gregor <span dir="ltr"><<a href="mailto:dgregor@apple.com" target="_blank" class="cremed">dgregor@apple.com</a>></span> wrote:<br>
<blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex"><div style="word-wrap:break-word"><br><div><div class="im"><div>On Dec 20, 2012, at 9:02 AM, Daniel Jasper <<a href="mailto:djasper@google.com" target="_blank" class="cremed">djasper@google.com</a>> wrote:</div>
<br><blockquote type="cite"><div style="font-family:arial,helvetica,sans-serif;font-size:10pt"><div dir="ltr">Hi,<div><br></div><div>ok, some comments here, but after the discussions it seems like this can mostly go in as is.</div>
<div>
<br></div><div><div>+ TT_BlockComment,</div><div>+ TT_ObjectiveCMethodDecl</div><div> };</div><div><br></div><div>The +/- actually determine whether it is an instance or a static method, right? If so, we might want to hint at that in this name.</div>
</div></div></div></blockquote><div><br></div></div><div>Yes, that's true. The formatter shouldn't care whether it's dealing with an instance vs. class method (they're conventionally formatted the same way), so why distinguish?</div>
</div></div></blockquote><div><br></div><div style="">That's not what I meant. I meant something like TT_ObjCStaticOrInstanceSpecifier (probably not a good name). But the enum value should say some thing about the single token and I was suspecting that the +/- by themselves are not method declarations.</div></div></div></div></div></blockquote><div><br></div><div>Ah. +/- are only used for method declarations, so TT_ObjCMethodSpecifier would be suitable descriptive.</div></div></div></blockquote><div><br></div>OK. I will use this name.</div><div><br></div><div>- Fariborz</div><div><br></div><br></body></html>