[cfe-commits] r170354 - in /cfe/trunk: include/clang/Basic/ObjCRuntime.h lib/CodeGen/CGObjC.cpp lib/CodeGen/CGObjCGNU.cpp lib/CodeGen/CGObjCMac.cpp lib/CodeGen/CGObjCRuntime.h test/CodeGenObjC/optimized-setter.m test/CodeGenObjCXX/property-object-reference-2.mm

[John McCall]

On Dec 17, 2012, at 11:14 AM, David Chisnall <csdavec at swan.ac.uk> wrote:
> On 17 Dec 2012, at 19:11, Rafael Espíndola wrote:
>>> static bool hasAtomicCopyHelperAPI(const ObjCRuntime &runtime) {
>>> -  // For now, only NeXT has these APIs.
>>> -  return runtime.isNeXTFamily();
>>> +  return runtime.hasAtomicCopyHelper();
>>> }
>> 
>> This function should probably just be inlined to all users, no?
> 
> Probably, but I'm not really sure why it existed in the first place.  

Most likely, it was abstracted out locally without considering that it should
just have been added to ObjCRuntime.

John.