[cfe-commits] [PATCH] Fix c-index-test warnings for gcc release build

Edwin Vane edwin.vane at intel.com
Mon Dec 17 10:58:00 PST 2012


Hi chapuni,

The release build was complaining about unused results from chdir(). Now
fixed.

Reviewed-By: Kevin P Schoedel <kevin.p.schoedel at intel.com>

http://llvm-reviews.chandlerc.com/D220

Files:
  tools/c-index-test/c-index-test.c

Index: tools/c-index-test/c-index-test.c
===================================================================
--- tools/c-index-test/c-index-test.c
+++ tools/c-index-test/c-index-test.c
@@ -2813,9 +2813,13 @@
         goto cdb_end;
       }
 
-      chdir(buildDir);
-      CCmds = clang_CompilationDatabase_getAllCompileCommands(db);
+      if (chdir(buildDir) != 0) {
+        printf("Could not chdir to %s\n", buildDir);
+        errorCode = -1;
+        goto cdb_end;
+      }
 
+      CCmds = clang_CompilationDatabase_getAllCompileCommands(db);
       if (!CCmds) {
         printf("compilation db is empty\n");
         errorCode = -1;
@@ -2834,7 +2838,11 @@
         CCmd = clang_CompileCommands_getCommand(CCmds, i);
 
         wd = clang_CompileCommand_getDirectory(CCmd);
-        chdir(clang_getCString(wd));
+        if (chdir(clang_getCString(wd)) != 0) {
+          printf("Could not chdir to %s\n", clang_getCString(wd));
+          errorCode = -1;
+          goto cdb_end;
+        }
         clang_disposeString(wd);
 
         numArgs = clang_CompileCommand_getNumArgs(CCmd);
-------------- next part --------------
A non-text attachment was scrubbed...
Name: D220.1.patch
Type: text/x-patch
Size: 1094 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/cfe-commits/attachments/20121217/8ce75af7/attachment.bin>


More information about the cfe-commits mailing list