[cfe-commits] [PATCH] Warn if -isysroot is given an invalid path

[Bob Wilson]

On Dec 14, 2012, at 10:28 AM, Argyrios Kyrtzidis <akyrtzi at gmail.com> wrote:

> On Dec 14, 2012, at 9:55 AM, Bob Wilson <bob.wilson at apple.com> wrote:
> 
>> 
>> On Dec 14, 2012, at 9:34 AM, Eric Christopher <echristo at gmail.com> wrote:
>> 
>>> 
>>> 
>>> 
>>> On Fri, Dec 14, 2012 at 9:29 AM, Jordan Rose <jordan_rose at apple.com> wrote:
>>>>> I can see bootstrapping scenarios such that you wouldn't want it. Possible to only put this warning into -Weverything and not into any other warning level? (TBH I didn't look at the patch so you may have done this…)
>>>> 
>>>> I didn't put it under -Weverything, but that's a good suggestion.  Thanks, Eric.
>>> 
>>> All warnings are under -Weverything. I think what Eric meant is that this should be DefaultIgnore.
>>> 
>>> 
>>> Um yeah, this. :)
>> 
>> I don't think it's worth doing if it is only enabled with -Weverything.  It might be better to just abandon this.
> 
> As Jordan said, it can be off by default and enabled with "-Wmissing-sysroot".

Sure, but I just don't see that providing much value.  The point of adding a warning was to help catch things like typos in the sysroot path.  What are the chances that someone is going to mis-type the sysroot and also specify -Wmissing-sysroot?  I'm assuming that typos are most likely to come up when someone is running the compiler by hand, rather than from a makefile.  I suppose that it could still help when a makefile specifies an SDK that is not currently installed.  I'm just not convinced that's worth the effort of adding and maintaining a new warning, but I'm open to being convinced.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.llvm.org/pipermail/cfe-commits/attachments/20121214/9dc28714/attachment.html>