<html><head><meta http-equiv="Content-Type" content="text/html charset=windows-1252"></head><body style="word-wrap: break-word; -webkit-nbsp-mode: space; -webkit-line-break: after-white-space; "><br><div><div>On Dec 14, 2012, at 10:28 AM, Argyrios Kyrtzidis <<a href="mailto:akyrtzi@gmail.com">akyrtzi@gmail.com</a>> wrote:</div><br class="Apple-interchange-newline"><blockquote type="cite"><meta http-equiv="Content-Type" content="text/html charset=windows-1252"><div style="word-wrap: break-word; -webkit-nbsp-mode: space; -webkit-line-break: after-white-space; "><div><div>On Dec 14, 2012, at 9:55 AM, Bob Wilson <<a href="mailto:bob.wilson@apple.com">bob.wilson@apple.com</a>> wrote:</div><br class="Apple-interchange-newline"><blockquote type="cite"><meta http-equiv="Content-Type" content="text/html charset=windows-1252"><div style="word-wrap: break-word; -webkit-nbsp-mode: space; -webkit-line-break: after-white-space; "><br><div><div>On Dec 14, 2012, at 9:34 AM, Eric Christopher <<a href="mailto:echristo@gmail.com">echristo@gmail.com</a>> wrote:</div><br class="Apple-interchange-newline"><blockquote type="cite"><br><div class="gmail_extra"><br><br><div class="gmail_quote">On Fri, Dec 14, 2012 at 9:29 AM, Jordan Rose <span dir="ltr"><<a href="mailto:jordan_rose@apple.com" target="_blank">jordan_rose@apple.com</a>></span> wrote:<br>
<blockquote class="gmail_quote" style="margin: 0px 0px 0px 0.8ex; border-left-width: 1px; border-left-color: rgb(204, 204, 204); border-left-style: solid; padding-left: 1ex; position: static; z-index: auto; "><div style="word-wrap:break-word"><div class="im"><div><blockquote type="cite"><div style="word-wrap:break-word"><blockquote type="cite">
<div class="gmail_extra"><div class="gmail_quote">I can see bootstrapping scenarios such that you wouldn't want it. Possible to only put this warning into -Weverything and not into any other warning level? (TBH I didn't look at the patch so you may have done this…)</div>
</div></blockquote><div><br></div><div>I didn't put it under -Weverything, but that's a good suggestion. Thanks, Eric.</div></div></blockquote></div><br></div><div><i>All</i> warnings are under -Weverything. I think what Eric meant is that this should be DefaultIgnore.</div>
<span class="HOEnZb"><font color="#888888"><br></font></span></div></blockquote><div><br></div><div>Um yeah, this. :)</div></div></div></blockquote><br></div><div>I don't think it's worth doing if it is only enabled with -Weverything. It might be better to just abandon this.</div></div></blockquote><div><br></div><div>As Jordan said, it can be off by default and enabled with "-Wmissing-sysroot".</div></div></div></blockquote><br></div><div>Sure, but I just don't see that providing much value. The point of adding a warning was to help catch things like typos in the sysroot path. What are the chances that someone is going to mis-type the sysroot and also specify -Wmissing-sysroot? I'm assuming that typos are most likely to come up when someone is running the compiler by hand, rather than from a makefile. I suppose that it could still help when a makefile specifies an SDK that is not currently installed. I'm just not convinced that's worth the effort of adding and maintaining a new warning, but I'm open to being convinced.</div></body></html>