[cfe-commits] r169041 - /cfe/trunk/lib/CodeGen/CGExpr.cpp

[David Blaikie]

On Fri, Nov 30, 2012 at 1:44 PM, Aaron Ballman <aaron at aaronballman.com> wrote:
> Author: aaronballman
> Date: Fri Nov 30 15:44:01 2012
> New Revision: 169041
>
> URL: http://llvm.org/viewvc/llvm-project?rev=169041&view=rev
> Log:
> Fixing a precedence issue with my previous commit.
>
> Modified:
>     cfe/trunk/lib/CodeGen/CGExpr.cpp
>
> Modified: cfe/trunk/lib/CodeGen/CGExpr.cpp
> URL: http://llvm.org/viewvc/llvm-project/cfe/trunk/lib/CodeGen/CGExpr.cpp?rev=169041&r1=169040&r2=169041&view=diff
> ==============================================================================
> --- cfe/trunk/lib/CodeGen/CGExpr.cpp (original)
> +++ cfe/trunk/lib/CodeGen/CGExpr.cpp Fri Nov 30 15:44:01 2012
> @@ -1950,7 +1950,7 @@
>    if (T->isIntegerType()) {
>      TypeKind = 0;
>      TypeInfo = (llvm::Log2_32(getContext().getTypeSize(T)) << 1) |
> -               T->isSignedIntegerType() ? 1 : 0;
> +               (T->isSignedIntegerType() ? 1 : 0);

Should you just drop the conditional operator entirely?
(should we have another class of -Wparentheses warning to catch this?)

>    } else if (T->isFloatingType()) {
>      TypeKind = 1;
>      TypeInfo = getContext().getTypeSize(T);
>
>
> _______________________________________________
> cfe-commits mailing list
> cfe-commits at cs.uiuc.edu
> http://lists.cs.uiuc.edu/mailman/listinfo/cfe-commits