[cfe-commits] [PATCH] Initial version of formatting library

Manuel Klimek klimek at google.com
Wed Nov 14 13:03:20 PST 2012


  Sean, this has been discussed multiple times now and there was general agreement that formatting will be needed by many tools (basically every time you refactor something, you'll need to fix up your formatting), and thus that it'd make sense to have it as a library.

  The second thing is that we would really appreciate some eyes on the basic assumptions we make to make sure we learn of possible problems down the path early on. I expect this to be a much higher probability if we develop it in clang directly.

  Lastly, if we agree that we'll want it to be in a library anyway, it seems to be a waste of effort to move stuff around later if there's not a strong argument for not having it in the main repo right away.

  I'm also not sure where you see the main-in-a-library pattern. Having a SourceManager with sources that you'll want to re-indent is exactly the state you're in after using the refactoring library to change your code.

http://llvm-reviews.chandlerc.com/D80



More information about the cfe-commits mailing list